Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle Class and other updates #204

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

ericstreit
Copy link
Contributor

still working on final mailroom but here is some of the older stuff. Primarily the Circle Class work. Only made it partially through the html renderer

@ericstreit
Copy link
Contributor Author

OK, my OO Mailroom is pretty much done. I still plan on include a sorting function so that displayed reports are done so alphabetically (or by total donation maybe) but if you want to review now, please feel free since it's 95% completed and I doubt I'll do any more retooling since I've spent well over 10 hours on this thing! Thanks for your feedback and hopefully my work isn't too ugly to review, I know that it didn't follow the framework as you had suggested.

I've never done this much coding before. After reviewing my work, I would also appreciate your thoughts on if I would survive the next class or not.

Thanks for your time!

@PythonCHB
Copy link
Contributor

Hopefully I'll have a chance ot give this a proper review soon. But for now, as for the next class.

If you think you could do similar assignments to these without too much pain, then you are ready to move on!

@PythonCHB
Copy link
Contributor

Gave you credit -- you pass!

But you really want to be able to "get: OO development. html_render is challenging, but it's supposed to be -- it requires a good understanding of subclassing, instance methods vs class attributes, etc....

So do try to finish that one!

@PythonCHB PythonCHB added the Credit Given Credit given in Canvas -- code not reviewed label Dec 17, 2018
@ericstreit
Copy link
Contributor Author

ericstreit commented Dec 17, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Credit Given Credit given in Canvas -- code not reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants