Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shayan's Onboarding #97

Closed
wants to merge 7 commits into from
Closed

Shayan's Onboarding #97

wants to merge 7 commits into from

Conversation

Shayan925
Copy link

Purpose

Explain the purpose of the PR here, including references to any existing Notion tasks.

New Changes

  • Explain new changes

Testing

  • Explain tests that you ran to verify code functionality.

Outstanding Changes

  • If there are non-critical changes (i.e. additional features) that can be made to this feature in the future, indicate them here.

@Shayan925 Shayan925 marked this pull request as ready for review October 11, 2023 02:22
@Shayan925 Shayan925 changed the title Draft Pull Request Shayan's Onboarding Oct 11, 2023
Copy link
Contributor

@Navtajh04 Navtajh04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple small changes

lm75bd/lm75bd.c Outdated Show resolved Hide resolved
lm75bd/lm75bd.c Outdated Show resolved Hide resolved
services/thermal_mgr/thermal_mgr.c Outdated Show resolved Hide resolved
services/thermal_mgr/thermal_mgr.c Outdated Show resolved Hide resolved
Copy link
Contributor

@Navtajh04 Navtajh04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Navtajh04 Navtajh04 closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants