Completed Bootcamp #93

orekk · 2023-09-17T23:49:33Z

Purpose

Implemented Temperature Sensor Driver Functions.
Created Thermal Management Task.
Added OS Handler for temperature sensor interrupts.

Changes

Defined LM75BD sensor's I2C device address.
Implemented readTempLM75BD function.
Created Thermal Management Task to collect temperature data.
Added OS Handler for LM75BD temperature sensor interrupts.

Testing

Unit tests passed for implemented functions.

Outstanding Changes

None.

Navtajh04

Looks good, just a few things, but I would try to fix the indentation to make it easier to read and review

lm75bd/lm75bd.c

Navtajh04 · 2023-09-17T23:58:58Z

lm75bd/lm75bd.c

+    const uint16_t sign_bit_mask = 0x0400;
+    const uint16_t temperature_bits_mask = 0x03FF;


use macros for these instead of const variables

Navtajh04 · 2023-09-17T23:59:44Z

lm75bd/lm75bd.c

+
+
+    // uint16_t numBytes = 2; 
+    errCode = i2cSendTo(devAddr,&pointer_register_value, 1U); // read the temperature from the sensor


not need to explicitly typecast the constant

Navtajh04 · 2023-09-18T00:01:50Z

services/thermal_mgr/thermal_mgr.c

+    error_code_t errCode = readTempLM75BD(LM75BD_OBC_I2C_ADDR, temperature); // Use your readTempLM75BD function
+
+    if (temperature > HYS_THRESHOLD) {
+        // Temperature is above or equal to the overtemperature threshold
+        overTemperatureDetected();
+    } else if (temperature <= HYS_THRESHOLD) {
+        // Temperature is below or equal to the hysteresis threshold
+        safeOperatingConditions(); 
+    }


we should not be calling readTemp in an ISR for 2 reasons

readTemp will call the i2c helper functions which will block on the I2C bus mutex and we should never be trying to block in an ISR

I2C is relatively slow and we want ISRs to always be as short and quick as possible to keep our system responsive

Navtajh04 · 2023-09-18T00:03:08Z

services/thermal_mgr/thermal_mgr.c

+  float* temperature;
+  // Question: a, I using the correct devAddr 
+    error_code_t errCode = readTempLM75BD(LM75BD_OBC_I2C_ADDR, temperature); // Use your readTempLM75BD function


since you are declaring temperature to be a pointer to a float but not setting it to anything, when you pass it into this function it is a NULL pointer so readTemp will return an error

Navtajh04 · 2023-09-18T00:03:40Z

services/thermal_mgr/thermal_mgr.c

@@ -43,18 +46,46 @@ void initThermalSystemManager(lm75bd_config_t *config) {

 error_code_t thermalMgrSendEvent(thermal_mgr_event_t *event) {
  /* Send an event to the thermal manager queue */
-


check if event is null

Navtajh04 · 2023-09-18T00:03:53Z

services/thermal_mgr/thermal_mgr.c

@@ -43,18 +46,46 @@ void initThermalSystemManager(lm75bd_config_t *config) {

 error_code_t thermalMgrSendEvent(thermal_mgr_event_t *event) {
  /* Send an event to the thermal manager queue */


check to make sure queue has been created

Navtajh04 · 2023-09-18T00:04:26Z

services/thermal_mgr/thermal_mgr.c

+  BaseType_t send = xQueueSend(thermalMgrQueueHandle, event, 0); // 0 ticks to wait 
+  if (send != pdPASS) return ERR_CODE_INVALID_QUEUE_MSG/*failed case*/;


you can just do if(xQueueSend(thermalMgrQueueHandle, event, 0) != pdPASS) instead of declaring a new variable

Navtajh04 · 2023-09-18T00:17:52Z

services/thermal_mgr/thermal_mgr.c

+					 if (errCode != ERR_CODE_SUCCESS) /*do something*/;
+			     // Send it as telemetry
+			     addTemperatureTelemetry(*temperature);


you shuld only be adding the telemetry temperature if the read was successful

Navtajh04 · 2023-09-18T00:18:09Z

services/thermal_mgr/thermal_mgr.c

+       // Kemi: Obtain type how
+			 if (receivedEvent.type == THERMAL_MGR_EVENT_MEASURE_TEMP_CMD) {
+			     // collect temperature data using drive fcn 
+			     float* temperature; 


same comment as in the os handler

Navtajh04

Just a couple more small changes

Navtajh04 · 2023-09-24T20:41:36Z

lm75bd/lm75bd.c

+
+    // to implement this we need to select the sensor's internaltemeprature register (7.4.1)
+	  uint8_t pointer_register_value = 0x00; // Point to the Temperature Register
+		devAddr = LM75BD_OBC_I2C_ADDR; 


device address is passed into the function, so you don't need to set it again. You can just use the address that was passed in, this is because if we have multiple lm75bd temperature sensors each would have a different address, so we would want the address to be a parameter to choose which sensor we want to read from

Navtajh04 · 2023-09-24T20:42:56Z

services/thermal_mgr/thermal_mgr.c

-
+  if(event == NULL) return ERR_CODE_INVALID_ARG; 
+  if(thermalMgrQueueHandle == NULL) return ERR_CODE_INVALID_QUEUE_MSG;
+  if (xQueueSend(thermalMgrQueueHandle, event, 0) != pdPASS) return ERR_CODE_INVALID_QUEUE_MSG/*failed case*/;


this function would only fail if the queue is full, not due to an invalid queue msg

Navtajh04 · 2023-09-24T20:44:59Z

services/thermal_mgr/thermal_mgr.c

+          // Team Lead -> u dont necessarily need to read the temperature in the OShandler, u just need a way to communicate that an 
+          // interrupt has happened so that u can read the temperature and deal with it from outside to OS handler
+          float temperature; 
+          error_code_t errCode = readTempLM75BD(LM75BD_OBC_I2C_ADDR, &temperature); // Use your readTempLM75BD function


check whether the readTempLM75BD was successful or not

Navtajh04

LGTM

Completed Bootcamp

46fbb5b

Navtajh04 requested changes Sep 18, 2023

View reviewed changes

Made requested changes

8623f97

Navtajh04 requested changes Sep 24, 2023

View reviewed changes

orek11 added 2 commits September 24, 2023 17:27

Made new requested changes

536d10b

One small change made

d96fb11

Navtajh04 reviewed Sep 25, 2023

View reviewed changes

Navtajh04 closed this Sep 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Completed Bootcamp #93

Completed Bootcamp #93

orekk commented Sep 17, 2023 •

edited

Loading

Navtajh04 left a comment

Navtajh04 Sep 17, 2023

Navtajh04 Sep 17, 2023

Navtajh04 Sep 18, 2023

Navtajh04 Sep 18, 2023

Navtajh04 Sep 18, 2023

Navtajh04 Sep 18, 2023

Navtajh04 Sep 18, 2023

Navtajh04 Sep 18, 2023

Navtajh04 Sep 18, 2023

Navtajh04 left a comment

Navtajh04 Sep 24, 2023

Navtajh04 Sep 24, 2023

Navtajh04 Sep 24, 2023

Navtajh04 left a comment

		const uint16_t sign_bit_mask = 0x0400;
		const uint16_t temperature_bits_mask = 0x03FF;



		// uint16_t numBytes = 2;
		errCode = i2cSendTo(devAddr,&pointer_register_value, 1U); // read the temperature from the sensor

		@@ -43,18 +46,46 @@ void initThermalSystemManager(lm75bd_config_t *config) {

		error_code_t thermalMgrSendEvent(thermal_mgr_event_t *event) {
		/* Send an event to the thermal manager queue */

		BaseType_t send = xQueueSend(thermalMgrQueueHandle, event, 0); // 0 ticks to wait
		if (send != pdPASS) return ERR_CODE_INVALID_QUEUE_MSG/failed case/;

Completed Bootcamp #93

Completed Bootcamp #93

Conversation

orekk commented Sep 17, 2023 • edited Loading

Purpose

Changes

Testing

Outstanding Changes

Navtajh04 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Navtajh04 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Navtajh04 left a comment

Choose a reason for hiding this comment

orekk commented Sep 17, 2023 •

edited

Loading