Adrian Ho UW Orbital Onboarding PR #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navtajh04
requested changes
Jul 21, 2023
services/thermal_mgr/thermal_mgr.h
Outdated
| @@ -5,6 +5,8 @@ | |||
|
|
|||
| typedef enum { | |||
| THERMAL_MGR_EVENT_MEASURE_TEMP_CMD, | |||
| THERMAL_MGR_EVENT_OVER_TEMP, | |||
| THERMAL_MGR_EVENT_AT_TEMP | |||
There was a problem hiding this comment.
This isn't used anywhere
services/thermal_mgr/thermal_mgr.c
Outdated
| } | ||
|
|
||
| void osHandlerLM75BD(void) { | ||
| /* Implement this function */ | ||
| thermal_mgr_event_t interrupt; | ||
| interrupt.type = THERMAL_MGR_EVENT_OVER_TEMP; |
There was a problem hiding this comment.
it would be better to name the type something else THERMAL_MGR_EVENT_OVER_TEMP is misleading since the interrupt would happen when we return to safe operating conditions as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Explain the purpose of the PR here, including references to any existing Notion tasks.
New Changes
Testing
Outstanding Changes