Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finn-Cullen-Onboarding-Challenge-Submission #194

Closed
wants to merge 6 commits into from

Conversation

FATCullen
Copy link

Purpose

Verify solutions to onboarding challenge

New Changes

Added thermal data reading and management

Testing

Ran unit and integration tests locally

Outstanding Changes

Copy link

@Yarik-Popov Yarik-Popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great start. Some changes are needed to improve the code quality

lm75bd/lm75bd.h Outdated Show resolved Hide resolved
services/thermal_mgr/thermal_mgr.c Outdated Show resolved Hide resolved
services/thermal_mgr/thermal_mgr.c Outdated Show resolved Hide resolved
lm75bd/lm75bd.c Show resolved Hide resolved
services/thermal_mgr/thermal_mgr.c Outdated Show resolved Hide resolved
Now returns all non-success error codes, OS handler now sends event instead of handling interrupts itself
Copy link

@Yarik-Popov Yarik-Popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing. Once this is handled, you are done the onboarding

services/thermal_mgr/thermal_mgr.c Show resolved Hide resolved
@Yarik-Popov
Copy link

Mb about the last comment. Lgtm, dm me your email and I'll add ou to the notion

@Yarik-Popov Yarik-Popov closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants