-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finn-Cullen-Onboarding-Challenge-Submission #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great start. Some changes are needed to improve the code quality
Now returns all non-success error codes, OS handler now sends event instead of handling interrupts itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing. Once this is handled, you are done the onboarding
Mb about the last comment. Lgtm, dm me your email and I'll add ou to the notion |
Purpose
Verify solutions to onboarding challenge
New Changes
Added thermal data reading and management
Testing
Ran unit and integration tests locally
Outstanding Changes