James Cai Onboarding #187
Closed
James Cai Onboarding #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yarik-Popov
requested changes
Oct 27, 2024
There was a problem hiding this comment.
Overall good start. Some changes are needed to improve the code quality.
Can you also add the c-programming-challenge-lvl1/ and Testing/ to the .gitignore? As there aren't 150 files that aren't relevant to the code when we are reviewing, making it harder to review it. Thanks
Yarik-Popov
reviewed
Oct 31, 2024
lm75bd/lm75bd.c
Outdated
|
|
||
| uint8_t writeBuf[1] = {0}; | ||
| uint8_t readBuf[2]; |
There was a problem hiding this comment.
Initialize the buffer. In general buffers should be initialized
|
lgtm, dm me your email and ill add you to the notion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.