Completed Onboarding #130
Open
Completed Onboarding #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yarik-Popov
requested changes
Mar 6, 2024
Comment on lines
+40
to
+48
| error_code_t errCode = i2cSendTo(devAddr, &writeBuf, 1); | ||
| if (errCode != ERR_CODE_SUCCESS){ | ||
| return errCode; | ||
| } | ||
|
|
||
| errCode = i2cReceiveFrom(devAddr, &readBuf, 2); | ||
| if (errCode != ERR_CODE_SUCCESS){ | ||
| return errCode; | ||
| } |
There was a problem hiding this comment.
Use RETURN_IF_ERROR_CODE() macro instead as it will also log the error code
|
|
||
| if(xQueueSend(thermalMgrQueueHandle, event, 0) == errQUEUE_FULL){ |
There was a problem hiding this comment.
Use pdFAIL instead of errQUEUE_FULL
Comment on lines
+63
to
+72
| float temp; | ||
| readTempLM75BD(LM75BD_OBC_I2C_ADDR, &temp); | ||
|
|
||
| if(temp > LM75BD_DEFAULT_HYST_THRESH){ | ||
| overTemperatureDetected(); | ||
| } | ||
| else if(temp <= LM75BD_DEFAULT_HYST_THRESH){ | ||
| safeOperatingConditions(); | ||
| } | ||
|
|
There was a problem hiding this comment.
As this is being called in it should be short, send an event to the queue indicating that it is an overtemperature event
| if(copiedData.type == THERMAL_MGR_EVENT_MEASURE_TEMP_CMD){ | ||
| errCode = readTempLM75BD(LM75BD_OBC_I2C_ADDR, &temp); | ||
| if(errCode != ERR_CODE_SUCCESS){ | ||
| printConsole("%d\n", errCode); |
dgobalak
requested changes
Mar 6, 2024
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| /* LM75BD Registers (p.8) */ | |||
| #define LM75BD_REG_CONF 0x01U /* Configuration Register (R/W) */ | |||
| #define LM75BD_REG_TEMP 0b00000000 /* Temperature Register */ | |||
There was a problem hiding this comment.
nit
Suggested change
| #define LM75BD_REG_TEMP 0b00000000 /* Temperature Register */ | |
| #define LM75BD_REG_TEMP 0x0U /* Temperature Register (R) */ |
| thermal_mgr_event_t copiedData; | ||
| error_code_t errCode; | ||
|
|
||
| if(xQueueReceive(thermalMgrQueueHandle, &copiedData, (TickType_t)10) == pdTRUE){ |
There was a problem hiding this comment.
Since this task doesn't do anything unless an event is received, just block indefinitely instead of using a block time of 10. This reduces CPU usage since the task would only unblock if it needs to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed unit tests and integration tests.
Completed building Temperature Sensor Driver Functions, Thermal Management Task, and OS handler.