Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rohan Mandhotra: UWOrbital Onboarding #125

Open
wants to merge 2 commits into
base: level3
Choose a base branch
from
Open

Rohan Mandhotra: UWOrbital Onboarding #125

wants to merge 2 commits into from

Conversation

RohanMandhotra
Copy link

Purpose

Finished implementing the LM75BD sensor functions, thermal management task and OS Handler

New Changes

  • Changed lm75bd.c, lm75bd.h, thermal_mgr.c, thermal_mgr.h

Testing

  • Ran integration and build tests and passed them without any errors

Navtajh04
Navtajh04 requested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@Navtajh04 Navtajh04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of changes

lm75bd/lm75bd.c
error_code_t readTempLM75BD(uint8_t devAddr, float *temp) {
/* Implement this driver function */

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if temp is NULL

services/thermal_mgr/thermal_mgr.c Outdated Show resolved Hide resolved
services/thermal_mgr/thermal_mgr.c
if (xQueueReceive(thermalMgrQueueHandle, &tempEvent, portMAX_DELAY) == pdTRUE){
if (tempEvent.type == THERMAL_MGR_EVENT_MEASURE_TEMP_CMD)
{
errCode = readTempLM75BD(LM75BD_OBC_I2C_ADDR, &tempVal);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be logged if it does not return success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Navtajh04 Navtajh04 Navtajh04 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RohanMandhotra @Navtajh04