Completed onboarding challenge #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Passed temperature sensor unit tests - Integration tests: Over temperature detected entering 82 degC; safe-temperature resumption detected at 74 degC. Implemented: - lm75bd.c readTempLM75BD function - thermal_mgr.c thermalMgr, osHandlerLM75BD functions
Navtajh04
requested changes
Nov 16, 2023
- null checks for events and thermalMgrQueueHandle - Modified thermalMgrSendEventISR to return ERR_CODE_QUEUE_FULL in event of xQueueSendFromISR fail - Modified thermalMgrSendEvent to return ERR_CODE_QUEUE_FULL in event of xQueueSend fail
leozqi
force-pushed
the
level3
branch
2 times, most recently
from
43e1ad8
to
ca8eaba
Compare
- Correct pdTrue, pdFalse to pdTRUE, pdFALSE
|
Thanks for your feedback @Navtajh04 , appreciate it! |
Navtajh04
requested changes
Nov 22, 2023
Navtajh04
requested changes
Dec 21, 2023
| } | ||
|
|
||
| float temp = {0}; | ||
| RETURN_IF_ERROR_CODE(readTempLM75BD(config.devAddr, &temp)); |
There was a problem hiding this comment.
This should just be a log if there's an error code followed by a continue since we should not be returning from FreeRTOS functions and especially since this is a void function and this would be returning an error code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Pull Request for Firmware Onboarding Challenge.
Suggestions and tips appreciated!
New Changes
Implemented:
Testing