finished onboarding challenge #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navtajh04
requested changes
Nov 3, 2023
services/thermal_mgr/thermal_mgr.c
Outdated
| if (xQueueReceive(thermalMgrQueueHandle, &event, 0) == pdTRUE) { // timeout? | ||
| switch (event.type) { | ||
| case THERMAL_MGR_EVENT_MEASURE_TEMP_CMD: | ||
| if (readTempLM75BD(config.devAddr, &temp) != ERR_CODE_SUCCESS) break; // What should be done if error? |
There was a problem hiding this comment.
Log the error if there was an error
There was a problem hiding this comment.
Also nitpick but I would explicitly use continue to make it more clear and also in case something is added after the switch case for some reason in the future (I don't see why this would happen though)
There was a problem hiding this comment.
I'm not sure I understand, I believe continue doesn't work in a switch case?
services/thermal_mgr/thermal_mgr.c
Outdated
| addTemperatureTelemetry(temp); | ||
| break; | ||
| case THERMAL_MGR_EVENT_INTERRUPT: | ||
| if (readTempLM75BD(config.devAddr, &temp) != ERR_CODE_SUCCESS) break; |
There was a problem hiding this comment.
log if this is an error code and continue;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Explain the purpose of the PR here, including references to any existing Notion tasks.
New Changes
Testing
Outstanding Changes