RESOPS142 - Remove docker port forwarding #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MNThomson
reviewed
Jun 16, 2024
TobySMurray
commented
Jun 18, 2024
TobySMurray
commented
Jun 18, 2024
TobySMurray
commented
Jun 18, 2024
MNThomson
approved these changes
Jun 18, 2024
christianbookout
pushed a commit
that referenced
this pull request
Jun 22, 2024
# Description <!-- Please include a summary of the change(s) and which issue is being fixed. Please provide as much detail as possible. --> Commenting out the ports for each service so they interact through the proxy rather than directly. <!-- Replace `XXX` with the concerning issue number. The "#" links this PR to its relevant issue --> Closes #142 ## How to Test <!-- Provide some simple steps so that others can verify your implementation --> Services should connect to their data stores without error. ## Checklist - [ ] The code includes tests if relevant - [ ] I have *actually* self-reviewed my changes and done QA <!-- Only check this off if you have actually done a self-review! DO NOT request any review from others until you have done your self-review! -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commenting out the ports for each service so they interact through the proxy rather than directly.
Closes #142
How to Test
Services should connect to their data stores without error.
Checklist