Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Add: Lead case study model #875

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

yashksaini-coder
Copy link
Contributor

Pull Request for PyVerse 💡

Requesting to submit a pull request to the PyVerse repository.


Issue Title

Please enter the title of the issue related to your pull request.
#860

  • I have provided the issue title.

Info about the Related Issue

What's the goal of the project?
Adding a Lead case study project that shows the different techniques which we can use to analyze the proper sales, with the different visualizations that allows us to see data analysis of various different factors & growths.

  • I have described the aim of the project.

Name

Please mention your name.
Yash K. Saini

  • I have provided my name.

GitHub ID

Please mention your GitHub ID.
yashksaini-coder

  • I have provided my GitHub ID.

Email ID

Please mention your email ID for further communication.
Enter your email ID here.

  • I have provided my email ID.

Identify Yourself

Mention in which program you are contributing (e.g., WoB, GSSOC, SSOC, SWOC).
GSSoC-Ext

  • I have mentioned my participant role.

Closes

Enter the issue number that will be closed through this PR.
#860

  • I have provided the issue number.

Type of Change

Select the type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how your changes have been tested.
I tested and generated plots

  • I have described my testing process.

Checklist

Please confirm the following:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@UTSAVS26
Copy link
Owner

@yashksaini-coder remove plus sign from the file name.

@yashksaini-coder
Copy link
Contributor Author

@yashksaini-coder remove plus sign from the file name.

I don't see a plus sign, which file u talking about ?

@UTSAVS26
Copy link
Owner

Data_Science/Lead Conversion Case Study/EDA+Feature Engineering+Outlier Analysis.ipynb

@yashksaini-coder
Copy link
Contributor Author

@UTSAVS26 bro done with the changes you can merge it now

@UTSAVS26 UTSAVS26 merged commit 5b11f48 into UTSAVS26:main Oct 28, 2024
@UTSAVS26 UTSAVS26 added Contributor Denotes issues or PRs submitted by contributors to acknowledge their participation. Status: Approved PRs that have passed review and are approved for merging. level1 gssoc-ext hacktoberfest hacktoberfest-accepted labels Oct 28, 2024
@yashksaini-coder yashksaini-coder deleted the yash/fix-860 branch October 28, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Denotes issues or PRs submitted by contributors to acknowledge their participation. gssoc-ext hacktoberfest hacktoberfest-accepted level1 Status: Approved PRs that have passed review and are approved for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants