Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#199 resizable dashboard #264

Merged
merged 13 commits into from
Nov 16, 2024

Conversation

HershLalwani
Copy link
Contributor

Overview

Completes #199

A way for the user to resize the RHS and LHS to improve readability of the compare tab and search list.

What Changed

Changes in dashboard/index.tsx swapped grid for react-resizable-panels to display the RHS & LHS. There are functions to show the correct UI when accessing from desktop or mobile.

Other Notes

Several Libraries were attempted, but react-resizable-panels worked best for our needs.

@HershLalwani HershLalwani linked an issue Oct 16, 2024 that may be closed by this pull request
6 tasks
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
utd-trends ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 1:57am

@TyHil
Copy link
Member

TyHil commented Oct 16, 2024

@AbhiramTadepalli double check LHS getting too small and mobile issues
maybe also snapping back to 50/50?

@TyHil
Copy link
Member

TyHil commented Oct 16, 2024

Mobile seems to work on chrome mobile for me but not firefox mobile, may just need to go back to the old Grid based on a useMediaQuery

@TyHil
Copy link
Member

TyHil commented Nov 5, 2024

@AbhiramTadepalli this should be ready now except I can't seem to get the sticky RHS working when merging in develop

@TyHil
Copy link
Member

TyHil commented Nov 6, 2024

@AbhiramTadepalli Ok figured it out. Apparently overflow hidden on any parents screws with position sticky. All ready now.

@AbhiramTadepalli
Copy link
Contributor

Okay so every time you add to compare it makes the rhs's minimum width wider. imo minwidth should stay the same because we have horizontal scroll in compare

@TyHil
Copy link
Member

TyHil commented Nov 12, 2024

Idk why setting min width fixes this but it does

@AbhiramTadepalli
Copy link
Contributor

@TyHil one last question
The LHS locks at a min-width. In split-screen (when the browser window is half the size) the RHS keeps going until the edge of the name. Is that the intended behavior?

In full-screen, the RHS just stops at the LHS's min-width

@AbhiramTadepalli
Copy link
Contributor

ah sorry. Bug:

  1. Make LHS bigger,
  2. open a card,
  3. make LHS smaller,
  4. the LHS does not get smaller, RHS just moves on top of it. Expected behavior is LHS resizes (including the contents of the card)

@TyHil
Copy link
Member

TyHil commented Nov 15, 2024

@TyHil one last question The LHS locks at a min-width. In split-screen (when the browser window is half the size) the RHS keeps going until the edge of the name. Is that the intended behavior?

In full-screen, the RHS just stops at the LHS's min-width

i dont't quite get this, can you screenshot?

ah sorry. Bug:
1. Make LHS bigger,
2. open a card,
3. make LHS smaller,
4. the LHS does not get smaller, RHS just moves on top of it. Expected behavior is LHS resizes (including the contents of the card)

im getting this behavior like 1 in 10 times, but if you re expand the LHS and re collapse it behaves as intended. is that acceptable?

@AbhiramTadepalli
Copy link
Contributor

@TyHil one last question The LHS locks at a min-width. In split-screen (when the browser window is half the size) the RHS keeps going until the edge of the name. Is that the intended behavior?
In full-screen, the RHS just stops at the LHS's min-width

i dont't quite get this, can you screenshot?

image
It covers the bubbles, does not make the row skinnier

@AbhiramTadepalli
Copy link
Contributor

im getting this behavior like 1 in 10 times, but if you re expand the LHS and re collapse it behaves as intended. is that acceptable?

Do you know why it's inconsistent? Or the cause?

@TyHil
Copy link
Member

TyHil commented Nov 16, 2024

I have no idea

@AbhiramTadepalli
Copy link
Contributor

AbhiramTadepalli commented Nov 16, 2024

Since it mostly works, I'll merge it in

Will be fixed later

Copy link
Contributor

@AbhiramTadepalli AbhiramTadepalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @HershLalwani

@AbhiramTadepalli AbhiramTadepalli merged commit 6c6610a into develop Nov 16, 2024
3 checks passed
@AbhiramTadepalli AbhiramTadepalli deleted the 199-feature-request-resizable-dashboard-page branch November 16, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Resizable Dashboard page
3 participants