-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#199 resizable dashboard #264
#199 resizable dashboard #264
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@AbhiramTadepalli double check LHS getting too small and mobile issues |
Mobile seems to work on chrome mobile for me but not firefox mobile, may just need to go back to the old Grid based on a useMediaQuery |
Make small screen vertical always
@AbhiramTadepalli this should be ready now except I can't seem to get the sticky RHS working when merging in develop |
@AbhiramTadepalli Ok figured it out. Apparently overflow hidden on any parents screws with position sticky. All ready now. |
Okay so every time you add to compare it makes the rhs's minimum width wider. imo minwidth should stay the same because we have horizontal scroll in compare |
Idk why setting min width fixes this but it does |
@TyHil one last question In full-screen, the RHS just stops at the LHS's min-width |
ah sorry. Bug:
|
i dont't quite get this, can you screenshot?
im getting this behavior like 1 in 10 times, but if you re expand the LHS and re collapse it behaves as intended. is that acceptable? |
|
Do you know why it's inconsistent? Or the cause? |
I have no idea |
Since it mostly works, I'll merge it in Will be fixed later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @HershLalwani
Overview
Completes #199
A way for the user to resize the RHS and LHS to improve readability of the compare tab and search list.
What Changed
Changes in dashboard/index.tsx swapped grid for react-resizable-panels to display the RHS & LHS. There are functions to show the correct UI when accessing from desktop or mobile.
Other Notes
Several Libraries were attempted, but react-resizable-panels worked best for our needs.