Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitLab as gold sponsor #30

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Add GitLab as gold sponsor #30

merged 4 commits into from
Apr 17, 2024

Conversation

jsubida
Copy link
Collaborator

@jsubida jsubida commented Apr 15, 2024

Description

Checklist:

  • (Committee Chairs Only) I have posted the link for the PR in the usrse slack (#usrse-2024-conference-planning-committee) to ask for content reviewers
  • I have previewed changes locally
  • I have updated the README.md if necessary

cc ADD GITHUB HANDLES HERE

Closes #28

@jsubida jsubida requested review from roelofsaj and mrmundt April 15, 2024 16:12
@jsubida
Copy link
Collaborator Author

jsubida commented Apr 15, 2024

image

@roelofsaj
Copy link
Contributor

roelofsaj commented Apr 16, 2024

Thanks for getting this up! The GitLab logo kind of dwarfs the Globus one, though... I know it's probably going to take up more space just because of its aspect ratio, but could it be a little smaller please?

@jsubida
Copy link
Collaborator Author

jsubida commented Apr 16, 2024

I think putting them side-by-side will help with perceived size differences. Perhaps a more sustainable solution would be to require a square icon for future sponsors? That way, wider logos won't appear bigger than their slimmer siblings.
image

@mrmundt
Copy link
Contributor

mrmundt commented Apr 16, 2024

I think putting them side-by-side will help with perceived size differences. Perhaps a more sustainable solution would be to require a square icon for future sponsors? That way, wider logos won't appear bigger than their slimmer siblings. image

FWIW, some places are very specific about having their name paired with the logo which makes it impossible to have as a square. So @roelofsaj ask for multiple versions if you can!

@jsubida
Copy link
Collaborator Author

jsubida commented Apr 16, 2024

Ah. Good point @mrmundt. Alternative solution?
image

@roelofsaj
Copy link
Contributor

I agree it's better, but the font & logo both still look overly large compared to the others on the page.

And thanks for the suggestion, @mrmundt -- I'll ask for additional options in future!

@jsubida
Copy link
Collaborator Author

jsubida commented Apr 17, 2024

@roelofsaj
image

@jsubida
Copy link
Collaborator Author

jsubida commented Apr 17, 2024

image

@mrmundt
Copy link
Contributor

mrmundt commented Apr 17, 2024

@jsubida - Oooo I like it now. Yes yes. Good good. A+.

@jsubida jsubida merged commit da5fe15 into USRSE:main Apr 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abbey Roelofs submitted a request due 2024-04-17
3 participants