Creates a dropdown menu in the navigation bar for the working groups #942
Conversation
|
I'm re-running the URL check, as the URLs that failed seem good. Can you also post the link to the preview, or a screenshot? |
Thanks for redoing the URL checks. I think the |
|
I think https://output.circle-artifacts.com/output/job/69a12ffd-95a9-4823-9007-26c8df8751a3/artifacts/0/usrse.github.io/index.html is a good preview page for people to look at |
|
The idea looks good. The links don't work in the preview, but my guess is this is an issue with the preview rather than the site. |
I've been noticing this on the last couple of PRs I've made as well. I think this is partially an issue either with CircleCI itself or the way we have it setup. The artifacts site doesn't seem to be able to handle the URL paths we expect. For example, we expect people to be able to go to https://us-rse.org/events/2022/2022-12-AGM/, but CircleCI seems to need us to add Also, we may have a problem with the way we use "baseurl" (maybe?), at least in terms of CircleCI. I've noticed just about every link you click on in CircleCI artifacts adds an extra "https://output.circle-artifacts.com/" to the front of the URL, e.g. https://output.circle-artifacts.com/https://output.circle-artifacts.com/output/job/69a12ffd-95a9-4823-9007-26c8df8751a3/artifacts/0/usrse.github.io/working-groups. But if you drop the additional https bit and add So with this and the |
|
FYI, I made the above comment an issue (#945) |
|
Can we help this progress somehow? |
Sorry I haven't really followed up on this much. I personally think it is good to go, but since it is something that is going to affect the entire website, I figured getting more eyes on it was best before merging. If you don't think that is necessary, then I can change it from draft and we can merge it in. |
- Adds the working groups as a navigation bar dropdown menu
- Moves the working groups landing page to be under the wg directory, to match the way we are handling other pages (like about landing) - Updates the Get Involved page to have the correct links to the working group pages - Adds a sidebar menu to the working group pages - Updates navigation to point to the new location of the working groups landing page
exoticDFT
force-pushed
the
updates/wg-top-menu
branch
from
a14afef
to
f6ed27c
Compare
- Re-adds the working groups page in the about dropdown, but points to new URL
|
Is the guideline for dead URLs related to jobs to just delete the job object in jobs.yaml? |
- Removes a job that has expired and has a dead URL
|
It is indeed, once you've checked manually that the link's dead, it's not just a false positive from the linkchecker. |
|
I'm happy to wait until more people review it, but I'm not sure how that will happen. Are you planning to ask specific people? |
- Moves the working groups drop down more towards the left in the navigation bar and shifts events right
@lparsons, @sk8forether, and I looked at this on my local machine during the DEI meeting. We made one more change and reviewed. So we're going to merge this now. |
|
This looks good, with one small issue. It makes the menu bar wider than the minimum size where the site changes, so at least for me, I no longer see the support button since it's now too far to the right to show up. See |
Description
Adds a new navbar dropdown menu for the working groups. Moves some source around to accommodate and to better match how we have other pages, like the About pages. I've also added a sidebar menu to all the WG pages, for easier navigation while on the pages. Lastly, there were a couple of mistaken links in the Get Involved page to the working group pages, so I fixed these.
Motivation and Context
A few of us were talking about adding the working groups in a more obvious way to the website. So we thought creating a new navbar dropdown for the pages would be good. This is an attempt at doing this. Any feedback would be great. I'm going to start this as a draft, so we can discuss any changes before making this official.
Checklist:
cc @usrse-maintainers