Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add white stripes to _nobackground logos #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cferenba
Copy link
Member

@cferenba cferenba commented Jun 5, 2020

This fixes a longstanding issue with the _nobackground versions of the logo: previously they were missing the white stripes in the speech bubble. This PR adds the stripes.

cc @usrse-maintainers

@cferenba
Copy link
Member Author

Just discovered that this fell through the cracks last year. @USRSE/usrse-maintainers can someone approve?

@cferenba cferenba requested a review from cmaimone March 17, 2021 18:49
@cmaimone
Copy link
Contributor

It looks like the font changed when you added the stripes - at least in the github preview
image

@cferenba
Copy link
Member Author

Hmm, it's rendering with the correct font for me:
image
I think this is a function of what fonts are available to your web browser.

@cmaimone
Copy link
Contributor

I don't have the same issue with the current image, so something changed. Plus it's still an issue if it shows up in a serif font for me -- we don't want people seeing it that way

@cferenba
Copy link
Member Author

Strange. Let me take a look...

@lparsons
Copy link
Member

Just a guess, but perhaps the font used to be embedded, but now it's not?

@cferenba
Copy link
Member Author

@lparsons your guess appears to be correct. In the old file I don't see either the font name or the US-RSE text anywhere, apparently the rendering is already embedded somehow.

@cferenba
Copy link
Member Author

Thinking about it some more: will most people see these .svg files directly, or will they see .png files generated from the .svg's? If the latter, it might not matter whether the .svg's render correctly in github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants