-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iws basin viz huc4s #12
base: IWS-basins
Are you sure you want to change the base?
Iws basin viz huc4s #12
Conversation
Merge branch 'add_rivers' of github.com:lindsayplatt/svg-maps into iws_basin_viz_huc4s # Conflicts: # 1_fetch.R # 2_process.R # 3_build.R
…s_basin_viz_huc4s
…'t slow down group_by>summarize
p1_huc4s_simp_sf, | ||
p1_huc4s_sf %>% | ||
st_intersection(p1_conus_sf) %>% | ||
rmapshaper::ms_simplify(0.01) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add a st_buffer(0)
before st_intersection
to bypass a self-intersection topology error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I add that in here? I didn't have to do that :(
tar_target( | ||
# Returns a list so that each river can be a separate SVG path | ||
p2_river_coords, | ||
sf_to_coords_by_id(needs_a_solution, | ||
sf_to_coords_by_id(p2_rivers_all_sf, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having separate SVG paths for each comid is probably more resolution than is needed for most projects. It might reduce file sizes to combine all separate paths that are the same style. Instead of having streams grouped by comid they could be grouped by basin and streamorder, so we can select by basin and style by streamorder. If streams are not connected we can draw a jump in a line by adding zm
between path d's .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we did want it by comid, the map will probably be much more local map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If streams are not connected we can draw a jump in a line by adding zm between path d's .
I'd love to hear more about this. The main reason I did it this way was so they wouldn't be connected.
change class and ids for huc4s
Shows basins by HUCs and then rivers. Specific to the IWS-basins viz, but we may end up merging some of the workflow over to the
main
branch at some point. Still waiting for this to build locally before calling it complete, but thought I'd put this up now.