Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test audit #426

Merged
merged 7 commits into from
Apr 3, 2023
Merged

Test audit #426

merged 7 commits into from
Apr 3, 2023

Conversation

dpgraham4401
Copy link
Member

@dpgraham4401 dpgraham4401 commented Apr 3, 2023

Description

This PR makes improvements to our trak and sites django app test suites.
For each unit test, we evaluated the following questions

  1. do we need it?
  2. Is it readable
  3. can we clearly discern the three stages, AAA

We also made some minor modification to things such as class names to be internally consistent, refactored a couple things to make use of Django and DRF's built in functionality to remove boilerplate, and update the server dependencies (see #423, and #424)

Issue ticket number and link

relevant to #128

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Other Stuff

@github-actions github-actions bot added server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included labels Apr 3, 2023
@dpgraham4401 dpgraham4401 merged commit c0f091a into USEPA:main Apr 3, 2023
@dpgraham4401 dpgraham4401 deleted the test_audit branch April 3, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant