Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client test additions #198

Merged
merged 14 commits into from
Nov 22, 2022
Merged

Client test additions #198

merged 14 commits into from
Nov 22, 2022

Conversation

dpgraham4401
Copy link
Member

@dpgraham4401 dpgraham4401 commented Nov 22, 2022 •
edited
Loading

Description

This PR cleans up a decent chunk of proof of concept code in the front end, adds a couple unit test for highly used components and a couple integration tests for Home, Login, and SiteList features.

Documentation changes accompanying the addition of a new front end environment variable Test which can be used to deploy the front end with mock http server via the msw library. It's not feature complete, and it's something that was already pulled in for it's use in the integration tests ( very cool library, wish I had known about it sooner).

Issue ticket number and link

I don't think this completes (fully) #128, There's still lots of room for high value tests.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Other Stuff

@dpgraham4401
move PrivateRoute to separate directory for consistency
6cd0d2a
@dpgraham4401
move userAppselector out of private route and pass as proops
4f68dba
@dpgraham4401
remove PrivateRoute test for now, clean up HtCard test
84d0c84
@dpgraham4401
add HtTooltip base test
3198b57
@dpgraham4401
add mock api calls, not working Home.spec.tsx
02c2a84
@dpgraham4401
reconfig to allow REACT_APP_HT_ENV to be 'PROD', 'DEV', or 'TEST', in…
02a27e2 
…itite MSW if 'TEST'
@dpgraham4401
little clean up
3ff749d
@dpgraham4401
update test-wrapper, inital test for Home component
f8b6014
@dpgraham4401
add simple tests for login and home components using new renderWithPr…
5f52bc3 
…ovider wrapper function
@dpgraham4401
fix auth returns user pk instead of username
2e41d8f
@dpgraham4401
fix bug fixes related to logout, strip more POC source
6f266d4
@dpgraham4401
add new Site type definition, added a test for, and cleaned up the Si…
2ae2014 
…teList component
@dpgraham4401 dpgraham4401 self-assigned this Nov 22, 2022
@github-actions github-actions bot added server Related to backend workings (Django/Rest API) client Related to front end workings (React/Redux) labels Nov 22, 2022
@dpgraham4401 dpgraham4401 changed the title Cleint test additions Client test additions Nov 22, 2022
@dpgraham4401 dpgraham4401 added the test Unit tests are, or need to be, included label Nov 22, 2022
@github-actions github-actions bot removed the test Unit tests are, or need to be, included label Nov 22, 2022
@dpgraham4401 dpgraham4401 merged commit 1e55d94 into USEPA:main Nov 22, 2022
@dpgraham4401 dpgraham4401 deleted the cleint_test_additions branch November 22, 2022 03:32
@dpgraham4401
Copy link
Member Author

partially covers #162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dpgraham4401 dpgraham4401

Labels
client Related to front end workings (React/Redux) server Related to backend workings (Django/Rest API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dpgraham4401