482 create tadamonitoringlocationidentifier in tada autoclean #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using TADA.MonitoringLocationIdentifier in TADA_FindNearbySites, changes made up through line 837
Update TADA_FindNearby to use TADA.MonitoringLocationIdentifier not MonitoringLocationIdentifier
Switch from MonitoringLocationIdentifier to TADA.MonitoringLocationIdentifier in depth profile functions, including documentation updates
Switched to using TADA.MonitoringLocationIdentifier in relevant functions
…er-in-tada_autoclean
Added TADA.MonitoringLocationName to TADA_Autoclean
Updated TADA_FindNearby to take into account org, meta data selection options, and create TADA.MonitoringLocationName
updated to use TADA.MonitoringLocationIdentifier for grouping and joining
Use TADA.MonitoringLocationIdentifier and TADA.MonitoringLocationName
Added identifier arg to TADA_OverviewMap
Updated overviewmap to include identifier param for wqp vs tada monitoring location data, added TADA.MonitoringLocationTypeName to autoclean, updated example data
TADA_GetUniqueNearbySites updates
Update TADA_FlaggedSites
Analysis filter bug fix
Updated metadata selection code to make it more efficient
Updates for efficient code and removing intermediate objects in meta data selection
Updated flags to make more specific
Started updates to TADA_FindPotentialDuplicatesMultipleOrgs (not yet complete)
Updates to find potential duplicates mulitple orgs
updates to TADA_FindPotentialDuplicatesSingleOrg - remove intermediate objects, suppress messages
updated order cols list
bug fix for TADA_FindNearby printing wrong messages
updates to duplicates test, flagging col name change, update global variables
bug fix
return to using suppressWarnings on URL check
potential fix for check() errors
potential bug fix
Fixed TADA_FindNearbySItes bug that occurred only in data sets where no groups of sites were found (also causing problems with finding multiple orgs dups and multiple orgs automated tests)
rearranged code related to bug fix for TADA_FindNearbySites
bug fixed - to correctly identify if no nearby sites are found
bug fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to TADA_FindNearby - submitting PR as I am having trouble running check() locally. I anticipate I will need to make some additional changes before it is ready for review.