Skip to content

Commit

Permalink
Merge pull request #23 from USDA-ARS-GBRU/dockerpatch
Browse files Browse the repository at this point in the history
Dockerpatch
  • Loading branch information
arivers authored Sep 15, 2023
2 parents 468271d + 2003834 commit c2d18f9
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 25 deletions.
16 changes: 8 additions & 8 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# v0.4.0

* changed the cli flag `--filter_by_locus` to `--filter_by_attribute` and added the flag `--attribute_key` so that keys other than the addribute key "locus_tag" can be filtered.
* Changed the cli to add `--raw_output_only`. This option allows the user to just get hte guides that met LSR and distance criteria without doing any parsing of the genome annotation files.
* updated caching for Streamlit 1.26
* updated GC and position methods for Biopython 1.8.1
* replaced append methods with concat methods for Pandas 2.1.1
* output data is now gzipped
* updated Dockerfile to use minimamba base image
*
* changed the cli flag `--filter_by_locus` to `--filter_by_attribute` and added the flag `--attribute_key` so that keys other than the addribute key "locus_tag" can be filtered.
* Changed the cli to add `--raw_output_only`. This option allows the user to just get hte guides that met LSR and distance criteria without doing any parsing of the genome annotation files.
* updated caching for Streamlit 1.26
* updated GC and position methods for Biopython 1.8.1
* replaced append methods with concat methods for Pandas 2.1.1
* output data is now gzipped
* updated Dockerfile to use minimamba base image
* Updates to python dependencies

5 changes: 0 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ docker pull ghcr.io/usda-ars-gbru/guidemaker-webapp
docker pull ghcr.io/usda-ars-gbru/guidemaker-nonavx
```


### Bioconda

```bash
Expand Down Expand Up @@ -71,10 +70,6 @@ guidemaker -h
guidemaker -h
```


```
### Dependencies

* ``pybedtools``
Expand Down
7 changes: 3 additions & 4 deletions coverage.xml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<?xml version="1.0" ?>
<coverage version="7.3.1" timestamp="1694793608190" lines-valid="1164" lines-covered="683" line-rate="0.5868" branches-covered="0" branches-valid="0" branch-rate="0" complexity="0">
<coverage version="7.3.1" timestamp="1694802720014" lines-valid="1163" lines-covered="682" line-rate="0.5864" branches-covered="0" branches-valid="0" branch-rate="0" complexity="0">
<!-- Generated by coverage.py: https://coverage.readthedocs.io/en/7.3.1 -->
<!-- Based on https://raw.githubusercontent.com/cobertura/web/master/htdocs/xml/coverage-04.dtd -->
<sources>
<source>/Users/rivers/Documents/guidemaker/guidemaker</source>
</sources>
<packages>
<package name="." line-rate="0.681" branch-rate="0" complexity="0">
<package name="." line-rate="0.6806" branch-rate="0" complexity="0">
<classes>
<class name="__init__.py" filename="__init__.py" complexity="0" line-rate="1" branch-rate="0">
<methods/>
Expand Down Expand Up @@ -70,7 +70,7 @@
<line number="85" hits="1"/>
</lines>
</class>
<class name="cli.py" filename="cli.py" complexity="0" line-rate="0.08152" branch-rate="0">
<class name="cli.py" filename="cli.py" complexity="0" line-rate="0.0765" branch-rate="0">
<methods/>
<lines>
<line number="6" hits="1"/>
Expand All @@ -80,7 +80,6 @@
<line number="11" hits="1"/>
<line number="12" hits="1"/>
<line number="13" hits="1"/>
<line number="14" hits="1"/>
<line number="16" hits="1"/>
<line number="17" hits="1"/>
<line number="19" hits="1"/>
Expand Down
5 changes: 3 additions & 2 deletions docker-images/nonavx/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,13 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
build-essential \
python3-dev \
zlib1g-dev \
git
git && apt-get clean \
&& rm -rf /var/lib/apt/lists/*
USER $MAMBA_USER

# RUN pip install --no-binary :all: nmslib

RUN git clone -b https://github.com/USDA-ARS-GBRU/GuideMaker.git && cd GuideMaker && pip install .
RUN git clone https://github.com/USDA-ARS-GBRU/GuideMaker.git && cd GuideMaker && pip install .

# port on the docker container
EXPOSE 8501
Expand Down
11 changes: 6 additions & 5 deletions docker-images/webapp/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,16 @@ ARG MAMBA_DOCKERFILE_ACTIVATE=1

USER root
RUN apt-get update && apt-get install -y --no-install-recommends \
build-essential \
python3-dev \
zlib1g-dev \
git
build-essential=12.9 \
python3-dev=3.9 \
zlib1g-dev=1.2 \
git=2.30 && apt-get clean \
&& rm -rf /var/lib/apt/lists/*
USER $MAMBA_USER

RUN pip install --no-binary :all: nmslib

RUN git clone -b https://github.com/USDA-ARS-GBRU/GuideMaker.git && cd GuideMaker && pip install .
RUN git clone https://github.com/USDA-ARS-GBRU/GuideMaker.git && cd GuideMaker && pip install .

# port on the docker container
EXPOSE 8501
Expand Down
2 changes: 1 addition & 1 deletion guidemaker/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import os
import yaml
import textwrap
import pandas as pd


import pybedtools
from Bio import SeqIO
Expand Down

0 comments on commit c2d18f9

Please sign in to comment.