Set default metrics for all datasets #229
Conversation
✅ Deploy Preview for ghg-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
@SwordSaintLancelot there seem to be indentation errors that caused the preview build to fail. See the CI job logs for details, please.
|
@j08lue I did look into the logs and it mentioned that the issue is with duplicate mapping keys for all the dataset files. I checked the indentation and it seems to be correct (at least similar to the example that you did) |
|
@SwordSaintLancelot don't add exclude to all the datasets, only to those that already had it |
Reverted them to their original state. |
package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "veda-config", | |||
| "description": "Configuration for Veda", | |||
| "version": "1.0.0-beta.2", | |||
| "version": "0.1.0", | |||
There was a problem hiding this comment.
Looks like this branch here should be rebased to current develop or something? Where you did you branch off from, @SwordSaintLancelot?
There was a problem hiding this comment.
I did branch it from develop. I will rebase it and push again. Also, this package was updated when I tried to view the changes in local netlify using the command yarn serve.
There was a problem hiding this comment.
Thanks. I was just worried about the "reverting" commits above. If these changes are already in develop by now and meant to be there, your commits here would undo them.
There was a problem hiding this comment.
I think there were a few changes that happened when I ran the yarn serve and that's what modified the /.veda/ui folder along with package.json but I changed those to original package.json which was in the develop branch.
SwordSaintLancelot
requested review from
j08lue
and removed request for
j08lue
SwordSaintLancelot
deleted the
update-default-metrics-for-dataset-layers
branch
j08lue
changed the title
Why are you creating this Pull Request?
The default metric has been added to all the layers of every dataset for the US GHG center.