-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#51] 이메일 인증 페이지 생성 #44
base: develop
Are you sure you want to change the base?
Conversation
gyuZzang
commented
Apr 17, 2021
•
edited
Loading
edited
- API (POST api/user/auth/{authCode}) 수정 및 스웨거에 적용하였으니, 확인부탁드립니다
- 기존에 params에 userId 넘기는 부분 삭제
- https://www.figma.com/file/UaucVQ5npc1KbT7YSYAL6f/UOSTime?node-id=195%3A156
src/utils/api.js
Outdated
export const API_SIGN_UP = makeAPI(POST, '/user'); | ||
export const API_FIND_ID = makeAPI(GET, '/user/id'); | ||
export const API_FIND_PW = makeAPI(GET, '/user/password'); | ||
export const API_SEND_CODE = makeAPI(POST, 'user/auth'); | ||
export const API_AUTH_EMAIL = (userID, code) => makeAPI(POST, `user/auth/${userID}/${code}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
함수로 만든 건 의도하신 건가요??
export const API_AUTH_EMAIL = (userID, code) => makeAPI(POST, `user/auth/${userID}/${code}`); | |
export const API_AUTH_EMAIL = makeAPI(POST, `/user/auth`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dormarble post (/user/auth) 에서 path params이 있는거랑 없는거랑 작동하는 방식이 다른데, api.js에는 하나로만 세팅하고, 프론트에서 API호출 시 setPathParams 세팅 여부에 따라 백에서 분기되는 건가요?
해당 사항 고려하여 API 변경점 재검토 부탁드리겠습니다. |
eslint 룰에 어긋나는 부분(quote, arrow-parens 등)이 많은데 확인이 필요합니다. |
이메일 입력 없이 코드 전송 요청할 수 있어 보완이 필요해보입니다. |