add can line validator #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zane-Larking
reviewed
May 6, 2024
|
|
||
| defined_can_names = get_all_defined_can() | ||
| print(f"all defined can line names = {defined_can_names}") | ||
|
|
||
| for definition_message_name in definition_message_names: | ||
| if definition_message_name not in can_message_names: |
There was a problem hiding this comment.
Shouldn't you also check that all can messages have a definitions.yml entry?
There was a problem hiding this comment.
I want to make it so that we can deprecate a message but still have its definition so that we could remove a part of the car and not have to write the message type when we re-add it to the car
Zane-Larking
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.