Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSH Keys Quickbyte #178

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

SSH Keys Quickbyte #178

wants to merge 4 commits into from

Conversation

rysc3
Copy link
Contributor

@rysc3 rysc3 commented May 22, 2024

No description provided.

@rysc3 rysc3 marked this pull request as ready for review May 22, 2024 04:38
@rysc3 rysc3 requested a review from gmfricke as a code owner May 22, 2024 04:38
@gmfricke gmfricke requested a review from mdunlavy May 28, 2024 22:58
@gmfricke gmfricke assigned gmfricke and rysc3 and unassigned gmfricke May 28, 2024
@rysc3 rysc3 requested a review from nap23carc June 11, 2024 23:02
nap23carc
nap23carc approved these changes Jun 13, 2024
View reviewed changes
Copy link

@nap23carc nap23carc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

gmfricke
gmfricke requested changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@gmfricke gmfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a recommendation that users set a password since anyone can use the file to login to any machine they setup with this key. A password only has to be entered once per session with a key manager so is more convenient, but provides security.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmfricke gmfricke gmfricke requested changes

@nap23carc nap23carc nap23carc approved these changes

@mdunlavy mdunlavy Awaiting requested review from mdunlavy

Requested changes must be addressed to merge this pull request.

Assignees

@rysc3 rysc3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rysc3 @gmfricke @nap23carc