Risk-risiko #152
Open
Risk-risiko #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and implemented function that prints results
makapx
requested changes
Oct 30, 2023
|
Non capisco che errori mi stia dando la pipeline, controllando nei check di github vedo solo che genera un'eccezione e dice che tutti i controlli falliscono ma senza darmi nessun motivo del perché |
TendTo
reviewed
Oct 30, 2023
src/risk-risiko.py
Outdated
| print(dices[1], "(M)") | ||
| print(dices[2], "(0)") | ||
|
|
||
| def printResults(red, blue): |
There was a problem hiding this comment.
Un po' di type hinting fa ssempre bene:
def randDice() -> int:
#....
def printDices(dices: list[int]):
#...
Il problema e' questo: sembra ci sia un accapo di troppo alla riga 30 |
TendTo
approved these changes
Oct 30, 2023
simone989
reviewed
Oct 31, 2023
| @@ -0,0 +1,29 @@ | |||
| import random | |||
There was a problem hiding this comment.
Importa solo la funzione randint dal modulo random.
simone989
reviewed
Oct 31, 2023
| import random | ||
|
|
||
| def randDice() -> int: | ||
| return random.randint(1, 6) |
There was a problem hiding this comment.
Definisci sempre i valori costanti in opportune variabili.
MIN_NUMBER=1
MAX_NUMBER= 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementate funzioni per stampare a schermo i dadi dei giocatori e per stampare i vincitori