Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: implementation of a calculator #302

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore: implementation of a calculator #302

wants to merge 8 commits into from

Conversation

Depoul
Copy link

@Depoul Depoul commented Oct 19, 2023

Implementation of a calculator, the operations are selectable by the user at runtime.

Helias
Helias reviewed Oct 19, 2023
View reviewed changes
exercises/calculator.cpp Outdated Show resolved Hide resolved
Helias
Helias reviewed Oct 19, 2023
View reviewed changes
exercises/calculator.cpp Outdated Show resolved Hide resolved
@Depoul
Copy link
Author

Depoul commented Oct 19, 2023

una volta applicate delle modifiche, devo effettuare una nuova pull request?

@Helias
Copy link
Member

Helias commented Oct 19, 2023

una volta applicate delle modifiche, devo effettuare una nuova pull request?

no, se vedi poco sopra la tua risposta c'è il commit che hai fatto, quando invii (push) un commit in una branch, se con questa branch hai aperto una PR, allora anche la PR verrà aggiornata

image

Comunque, nota che nella pipeline, lo step "cpp-check" si lamenta di qualcosa, clicca su Details e vedi cos'è

Helias
Helias reviewed Oct 19, 2023
View reviewed changes
exercises/calculator.cpp Outdated Show resolved Hide resolved
@Depoul
Copy link
Author

Depoul commented Oct 20, 2023

Il fatto che la pipeline restituisca errori, è un processo automatico o dipende da te?

@Helias
Copy link
Member

Helias commented Oct 20, 2023

Il fatto che la pipeline restituisca errori, è un processo automatico o dipende da te?

Purtroppo per i nuovi utenti di GitHub le pipeline sono "bloccate" e le devo "approvare", appena clicco "approva" si avviano e fanno tutto in automatico

Helias
Helias reviewed Oct 21, 2023
View reviewed changes
exercises/calculator.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helias Helias Helias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Depoul @Helias