Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed docker-compose.yml and renamed gdal_rio.env to .env.example #88

Merged
merged 3 commits into from
Apr 9, 2024
Merged

fix: fixed docker-compose.yml and renamed gdal_rio.env to .env.example #88

merged 3 commits into from
Apr 9, 2024

Conversation

JinIgarashi
Copy link
Contributor

@JinIgarashi JinIgarashi commented Apr 9, 2024 •
edited
Loading

@iferencik please review these changes

  • switched ENV to ARG in Dockefile, so these variables can be passed do docker from environmental variables correctly.
  • renamed gdal_rio.env to .env.example (you need to do cp .env.example .env first)
  • fixed docker-compose.yml.
    • spacified platform, so it can work with MacOS, too
    • deleted container name from yaml
    • delete unnecessary environment settings

@JinIgarashi JinIgarashi added the bug Something isn't working label Apr 9, 2024
@JinIgarashi JinIgarashi marked this pull request as draft April 9, 2024 05:22
@JinIgarashi JinIgarashi self-assigned this Apr 9, 2024
@JinIgarashi JinIgarashi marked this pull request as ready for review April 9, 2024 05:52
@iferencik iferencik merged commit 1d6e5ad into main Apr 9, 2024
1 check passed
@iferencik iferencik deleted the fix/dockercompose branch April 9, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iferencik iferencik Awaiting requested review from iferencik

Assignees

@JinIgarashi JinIgarashi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JinIgarashi @iferencik