fix: prevent page from crashing if no config found for network/safe #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ry-crashes-proposal-page
daywiss
approved these changes
Apr 19, 2024
gsteenkamp89
added a commit
that referenced
this pull request
Apr 26, 2024
gsteenkamp89
added a commit
that referenced
this pull request
Jul 3, 2024
* fix: prevent page from crashing if no config found for network/safe (#164) * add multiple safes to builder * small refactor & fix safe dropdown options * ensure proposal page can handle single and multi safe proposals * clean up * handle switching networks gracefully for execution * edit styles from feedback --------- Co-authored-by: Chaitanya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation
also closes UMA-2549
We now load all safes that meet criteria:
In the case we can a safe defined in our space settings that does not meet these criteria, we just filter those out and display the ones that do. Show meaningful error in console.