Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional reference numbers to Refund route #231

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

ChisomOguibe11
Copy link
Contributor

Business have requested that additional options be made available in answer to the question "Which, if any, of the following reference numbers do you have?" in the Refund journey.

They would like:

Case ID
Any payment reference
Any other reference

to be added to the list of potential options.

Repo Changes:

  • Added additional fields in fields.json and pages.json
  • Append those fields inside fields array for url path /application-ref-numbers
  • Add same reference validation style for added fields in fields/index.js

Reference:

https://collaboration.homeoffice.gov.uk/jira/browse/UKVIC-156

…, if any, of the following reference numbers do you have"

- Added additional fields in fields.json and pages.json
- Append those fields inside fields array for url path /application-ref-numbers
- Add same reference validation style for added fields in fields/index.js
@ChisomOguibe11 ChisomOguibe11 marked this pull request as ready for review February 1, 2023 12:59
improve error message for notUrl validation on new inputs
@RobertMcCann
Copy link

looks good to me

@Alex-Swann Alex-Swann changed the base branch from main to master February 20, 2023 12:54
Copy link
Contributor

@shamiluwais shamiluwais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants