-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional reference numbers to Refund route #231
Open
ChisomOguibe11
wants to merge
19
commits into
master
Choose a base branch
from
UKVIC-156
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, if any, of the following reference numbers do you have" - Added additional fields in fields.json and pages.json - Append those fields inside fields array for url path /application-ref-numbers - Add same reference validation style for added fields in fields/index.js
RobertMcCann
reviewed
Feb 2, 2023
RobertMcCann
reviewed
Feb 2, 2023
improve error message for notUrl validation on new inputs
looks good to me |
….json schema + add unit tests for reference fields
…, if any, of the following reference numbers do you have" - Added additional fields in fields.json and pages.json - Append those fields inside fields array for url path /application-ref-numbers - Add same reference validation style for added fields in fields/index.js
improve error message for notUrl validation on new inputs
….json schema + add unit tests for reference fields
shamiluwais
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Business have requested that additional options be made available in answer to the question "Which, if any, of the following reference numbers do you have?" in the Refund journey.
They would like:
Case ID
Any payment reference
Any other reference
to be added to the list of potential options.
Repo Changes:
Reference:
https://collaboration.homeoffice.gov.uk/jira/browse/UKVIC-156