-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOF-8: Add logger and surpress logging during testing #127
Open
joehod
wants to merge
72
commits into
master
Choose a base branch
from
hof-8-supress-logging-in-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joehod
commented
May 4, 2021
- Added a logToKibana function to utils that is responsible for logging information whether the complaint is submitted successfully or not.
- Add option to suppress logging if running tests to make it easier to read the output from each test.
…k queue Add behaviour for SQS integration using sqs-producer Add instructions and queue url to config Add instruction for reading what is on the queue
* Made initial functions to fit submitting application complaint to schema * Assign agent phone to agent details * Add formatting for delay complaints * Move complaintDetails to Parent class constructor and add individual complaint details to child constructor * Add format classes for somethingElse and Existing complaint * Finish formatting for StaffBehaviour * Use hof behaviour functions in behaviour
* Set up tests for AddToCasework * Add tests for complaint base class * Add tests for utils * Add tests for formatComplaintData * Add test for json-converters * Add test for validator throwing errror when undefined value passed in
* SD-272: add custom error page for form failing to submit to queue * SD-272: add max length constraint on all text fields * Add sqs queue config to config file * Increase test timeout * Remove integration test folder * Update node version and fix emailCasweworker config setting * update complaint details max length
…t class and single list of enums
changed preprod namespace to new preprod namespace
* Updated eslint to version 7.22.0 * Updated .eslintrc file * Fixed the failing eslint errors.
…ng-and-fix-errors SD-720: Fixed eslint errors and upgraded eslint
…k queue Add behaviour for SQS integration using sqs-producer Add instructions and queue url to config Add instruction for reading what is on the queue
* Made initial functions to fit submitting application complaint to schema * Assign agent phone to agent details * Add formatting for delay complaints * Move complaintDetails to Parent class constructor and add individual complaint details to child constructor * Add format classes for somethingElse and Existing complaint * Finish formatting for StaffBehaviour * Use hof behaviour functions in behaviour
* Set up tests for AddToCasework * Add tests for complaint base class * Add tests for utils * Add tests for formatComplaintData * Add test for json-converters * Add test for validator throwing errror when undefined value passed in
* SD-272: add custom error page for form failing to submit to queue * SD-272: add max length constraint on all text fields * Add sqs queue config to config file * Increase test timeout * Remove integration test folder * Update node version and fix emailCasweworker config setting * update complaint details max length
…t class and single list of enums
* Updated image in drone pipeline build step to node:14 * Changed docker image from node:10-alpine to node:14-alpine. * Updated package.json to include node version "14.16.1"
…k queue Add behaviour for SQS integration using sqs-producer Add instructions and queue url to config Add instruction for reading what is on the queue
* Made initial functions to fit submitting application complaint to schema * Assign agent phone to agent details * Add formatting for delay complaints * Move complaintDetails to Parent class constructor and add individual complaint details to child constructor * Add format classes for somethingElse and Existing complaint * Finish formatting for StaffBehaviour * Use hof behaviour functions in behaviour
* Set up tests for AddToCasework * Add tests for complaint base class * Add tests for utils * Add tests for formatComplaintData * Add test for json-converters * Add test for validator throwing errror when undefined value passed in
* SD-272: add custom error page for form failing to submit to queue * SD-272: add max length constraint on all text fields * Add sqs queue config to config file * Increase test timeout * Remove integration test folder * Update node version and fix emailCasweworker config setting * update complaint details max length
…t class and single list of enums
SD 272: decs integration
Add max-lengths to city type in schema
HOF-7-existing-complaint-bug
Hof 6 improve logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.