Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: HOF-3 / HOF-5: Add integration tests to pipeline #126

Open
wants to merge 77 commits into
base: master
Choose a base branch
from
Open

WIP: HOF-3 / HOF-5: Add integration tests to pipeline #126

wants to merge 77 commits into from

Conversation

MaxOSullivan
Copy link
Contributor

What

  • Add mock SQS queue Dockerfile to initiate docker instance for the mock queue
  • Edit config file to use mock SQS queue settings when the user runs the mock service
  • Edit README to include new information about mock service and tests
  • Rework index file to allow automated testing
  • Add multiple scripts to package.json file to test integration and set up mock queue
  • Add integration tests and test helper file
  • Rework Drone pipeline to have a test step which runs the linting, unit and new integration test

Joseph Coker and others added 30 commits April 12, 2021 15:46
Add sql-producer behaviour and instructions for setting up local stac…
c1812d2 
…k queue

Add behaviour for SQS integration using sqs-producer

Add instructions and queue url to config

Add instruction for reading what is on the queue
Add behaviour to convert form complaints data to fit DECS schema
caf52b6 
* Made initial functions to fit submitting application complaint to schema
* Assign agent phone to agent details
* Add formatting for delay complaints
* Move complaintDetails to Parent class constructor and add individual complaint details to child constructor
* Add format classes for somethingElse and Existing complaint
* Finish formatting for StaffBehaviour
* Use hof behaviour functions in behaviour
Add tests checking complaint data formatting is correct
7fa9ecf 
* Set up tests for AddToCasework
* Add tests for complaint base class
* Add tests for utils
* Add tests for formatComplaintData
* Add test for json-converters
* Add test for validator throwing errror when undefined value passed in
@MaxOSullivan
Update node version and sql queue config
dc59eb4 
* SD-272: add custom error page for form failing to submit to queue
* SD-272: add max length constraint on all text fields
* Add sqs queue config to config file
* Increase test timeout
* Remove integration test folder
* Update node version and fix emailCasweworker config setting
* update complaint details max length
Update eslint version and fix linting errors
4d753af
Add function to convert enums across complaint types to base complain…
8bb2634 
…t class and single list of enums
inject validator as argument to validAgainstSchema, add validatorFactory
bec1e53
Add logging of send to queue response
147c0f9
changed preprod namespace to new preprod namespace
adb6736
@James-Hovell
Merge pull request #113 from UKHomeOffice/SD-710-new-preprod-env
ab0a748 
changed preprod namespace to new preprod namespace
@SarahJaneLuff
SD-720: Fixed eslint errors and upgraded eslint
7e94623 
	* Updated eslint to version 7.22.0
	* Updated .eslintrc file
	* Fixed the failing eslint errors.
@joehod
Merge pull request #114 from UKHomeOffice/feature/SD-720-Update-Linti…
0f4f072 
…ng-and-fix-errors

SD-720: Fixed eslint errors and upgraded eslint
Add tests for send-to-sqs
ceac847
Add meaningful error messages to util functions
56f16ff
readme
bd50ba9
@James-Hovell
Merge pull request #115 from UKHomeOffice/SD-710-new-preprod-env
9332cd7 
readme
Add sql-producer behaviour and instructions for setting up local stac…
2dc5afa 
…k queue

Add behaviour for SQS integration using sqs-producer

Add instructions and queue url to config

Add instruction for reading what is on the queue
Add behaviour to convert form complaints data to fit DECS schema
ee3a483 
* Made initial functions to fit submitting application complaint to schema
* Assign agent phone to agent details
* Add formatting for delay complaints
* Move complaintDetails to Parent class constructor and add individual complaint details to child constructor
* Add format classes for somethingElse and Existing complaint
* Finish formatting for StaffBehaviour
* Use hof behaviour functions in behaviour
Add tests checking complaint data formatting is correct
ef7868c 
* Set up tests for AddToCasework
* Add tests for complaint base class
* Add tests for utils
* Add tests for formatComplaintData
* Add test for json-converters
* Add test for validator throwing errror when undefined value passed in
@MaxOSullivan
Update node version and sql queue config
97e0962 
* SD-272: add custom error page for form failing to submit to queue
* SD-272: add max length constraint on all text fields
* Add sqs queue config to config file
* Increase test timeout
* Remove integration test folder
* Update node version and fix emailCasweworker config setting
* update complaint details max length
Update eslint version and fix linting errors
aa751ef
Add function to convert enums across complaint types to base complain…
38ced3b 
…t class and single list of enums
inject validator as argument to validAgainstSchema, add validatorFactory
683244a
Add logging of send to queue response
d2d779a
Add tests for send-to-sqs
17b336c
Add meaningful error messages to util functions
26f30e9
rebase from master
19a3e91
Update package lock
e5ece04
@SarahJaneLuff
SD-725: Upgrade Node Version to 14
33cc247 
	* Updated image in drone pipeline build step to node:14
	* Changed docker image from node:10-alpine to node:14-alpine.
	* Updated package.json to include node version "14.16.1"
@SarahJaneLuff
SD-725: Corrected Typo Error in .drone.yml file for feature branch ev…
3302c4d 
…ents
MaxOSullivan and others added 26 commits April 20, 2021 12:54
@MaxOSullivan
Update node version and sql queue config
7410edf 
* SD-272: add custom error page for form failing to submit to queue
* SD-272: add max length constraint on all text fields
* Add sqs queue config to config file
* Increase test timeout
* Remove integration test folder
* Update node version and fix emailCasweworker config setting
* update complaint details max length
Update eslint version and fix linting errors
5738272
Add function to convert enums across complaint types to base complain…
502e0c9 
…t class and single list of enums
inject validator as argument to validAgainstSchema, add validatorFactory
d9d2f1c
Add logging of send to queue response
5b492db
Add tests for send-to-sqs
fd0d8f0
Add meaningful error messages to util functions
5014a42
Refactor to json converters to functional approach
ec748b4
Fix merge conflicts with remote
fdfbf89
Fix sendToQueue config option and add test
4445851
Add fallback stub email to config
f8bb068
@joehod
Merge pull request #110 from UKHomeOffice/SD-272-DECS-integration
ff7be9d 
SD 272: decs integration
Add max-lengths to city type in schema
15a43e4
@SarahJaneLuff
Merge pull request #123 from UKHomeOffice/SD-272-update-decs-schema
69363df 
Add max-lengths to city type in schema
Move addition of reporter details to optional if acting-as-agent valu…
dbce7de 
…e present
@MaxOSullivan
Merge pull request #124 from UKHomeOffice/HOF-7-existing-complaint-bug
dd3166c 
HOF-7-existing-complaint-bug
@MaxOSullivan
HOF-3: update README to include context around queue and mock service…
cda43c0 
… info
@MaxOSullivan
Add mock sqs details to config for use within mock service
e8a84d0
@MaxOSullivan
rework index file to allow automated testing
2cb2381
@MaxOSullivan
add scripts to run mock service and run automated tests
0ef4a09
@MaxOSullivan
add mock sqs setup files and integration tests
e938c61
@MaxOSullivan
edit drone pipeline to start redis instance before automated tests run
1e2e6ef
@MaxOSullivan
change drone pipeline to working version
3e23d5a
@MaxOSullivan
rework drone file to use mock-sqs as a service
0fe25c9
@MaxOSullivan
readme update to reflect changes
d14b28b
@MaxOSullivan
edit package.json scripts and pipeline to separate test scripts
6344d90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MaxOSullivan @James-Hovell @SarahJaneLuff @joehod @sulthan-ahmed