Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav implementation #290

Open
wants to merge 4 commits into
base: leader
Choose a base branch
from
Open

Nav implementation #290

wants to merge 4 commits into from

Conversation

jacksonhyde
Copy link
Contributor

  • Implements new nav
  • Defaults to national dashboard when user has correct rights

@jacksonhyde jacksonhyde force-pushed the nav-implementation branch 3 times, most recently from 2d454a1 to 97b6532 Compare August 28, 2024 19:02
richbirch
richbirch reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@richbirch richbirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A few minor things.

Before we merge this it's going to need some really thorough user testing in preprod

Dockerfile Outdated Show resolved Hide resolved
react/src/airports.ts Outdated Show resolved Hide resolved
react/src/airports.ts Outdated Show resolved Hide resolved
react/src/App.tsx Outdated Show resolved Hide resolved
@jacksonhyde jacksonhyde force-pushed the nav-implementation branch 2 times, most recently from 0098837 to 788f11a Compare October 10, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richbirch richbirch richbirch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacksonhyde @richbirch