Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: change required provider version #25

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

LiamMacP
Copy link
Contributor

@LiamMacP LiamMacP commented Mar 11, 2024

The old version meant callees had to adhere to the provider version causing issues. This change allows the modules to accept everything upstream that is within the major version 5; following best practices by Terraform.

Best practice:

Do not use ~> (or other maximum-version constraints) for modules you intend to reuse across many configurations
https://developer.hashicorp.com/terraform/language/providers/requirements#best-practices-for-provider-versions

It has still been decided in the immediate future to peg within major version 5.

The old version meant callees had to adhere to the provider version
causing issues. This change allows the modules to accept everything
upstream that is within the major version 5; following best practices by
Terraform.
@LiamMacP LiamMacP force-pushed the fix/update-module-versions-min-max branch from cb7b39e to d233268 Compare March 11, 2024 12:50
@LiamMacP LiamMacP merged commit 4d86b66 into main Mar 11, 2024
2 checks passed
@LiamMacP LiamMacP deleted the fix/update-module-versions-min-max branch March 11, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants