[ASL-4590] Limit injecting licence holder field to PDF (#954)

client/schema/index.js

@@ -26,28 +26,13 @@ export function getGrantedSubsections(schemaVersion) {
 
 export function getSubsections(schemaVersion) {
   const schema = versions[schemaVersion];
-  const subsections = Object.values(schema())
+  return Object.values(schema())
     .reduce((sections, section) => {
       return {
         ...sections,
         ...(section.subsections || {})
       };
     }, {});
-
-  if (schemaVersion === 1) {
-    // inject the project licence holder into introductory details
-    const field = [
-      {
-        label: 'Licence holder',
-        name: 'licenceHolder',
-        type: 'holder-name'
-      }
-    ];
-
-    subsections['introduction'].fields.splice(1, 0, field);
-  }
-
-  return subsections;
 }
 
 export default versions;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@asl/projects",
-  "version": "15.6.8",
+  "version": "15.6.9",
   "description": "ASL PPL prototype",
   "main": "client/external.js",
   "styles": "assets/scss/projects.scss",

views/pdf/v1/index.jsx

@@ -5,12 +5,27 @@ import { getGrantedSubsections, getSubsections } from '../../../client/schema';
 import StaticSection from '../../../client/components/static-section';
 import StandardConditions from '../components/standard-conditions';
 
+function injectLicenceHolder(subsections) {
+  // inject the project licence holder into introductory details
+  const field = [
+    {
+      label: 'Licence holder',
+      name: 'licenceHolder',
+      type: 'holder-name'
+    }
+  ];
+
+  subsections['introduction'].fields.splice(1, 0, field);
+
+  return subsections;
+}
+
 export default function PDF() {
   const project = useSelector(state => state.project);
   const isFullApplication = useSelector(state => state.application.isFullApplication);
 
   const sections = isFullApplication
-    ? Object.values(getSubsections(1))
+    ? Object.values(injectLicenceHolder(getSubsections(1)))
       .filter(s => !s.show || s.show(project))
     : Object.values(getGrantedSubsections(1))
       .filter(s => !s.granted.show || s.granted.show(project))
@@ -31,5 +46,5 @@ export default function PDF() {
         !isFullApplication && <StandardConditions />
       }
     </div>
-  )
+  );
 }