-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spaces can now join the hackspace foundation #125
Open
castaway
wants to merge
6
commits into
main
Choose a base branch
from
castaway/space_membership
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
castaway
commented
Jul 2, 2019
- Send user-in-space approval email when user changes their space on the profile page
- Show space-joining-foundation form
- Send approval email from space-joining form, to board
- Board can approve/reject space-joining
- Gocardless mandates set up for spaces, and payments requested
- User profile page shows status of their space's joining request / payments
Exciting! |
main/models/gocardless_mandate.py
Outdated
@@ -24,7 +24,20 @@ def get_mandate_for_supporter_membership(self, supporter_membership): | |||
def get_membership_status_for_supporter_membership(self, supporter_membership): | |||
return self.get_mandate_for_supporter_membership(supporter_membership).status | |||
|
|||
# get_or_create that populates fields from json | |||
# get all mandate records for space membership |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation here looks out.
unknowndomain
requested changes
Dec 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments attached, mostly looks fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.