Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces can now join the hackspace foundation #125

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

castaway
Copy link
Contributor

@castaway castaway commented Jul 2, 2019

  • Send user-in-space approval email when user changes their space on the profile page
  • Show space-joining-foundation form
  • Send approval email from space-joining form, to board
  • Board can approve/reject space-joining
  • Gocardless mandates set up for spaces, and payments requested
  • User profile page shows status of their space's joining request / payments

@Jonty
Copy link
Contributor

Jonty commented Jul 2, 2019

Exciting!

@@ -24,7 +24,20 @@ def get_mandate_for_supporter_membership(self, supporter_membership):
def get_membership_status_for_supporter_membership(self, supporter_membership):
return self.get_mandate_for_supporter_membership(supporter_membership).status

# get_or_create that populates fields from json
# get all mandate records for space membership
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation here looks out.

Copy link
Contributor

@unknowndomain unknowndomain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments attached, mostly looks fine.

main/models/space.py Outdated Show resolved Hide resolved
main/templates/join_space/step1.html Outdated Show resolved Hide resolved
main/templates/join_space/step1.html Show resolved Hide resolved
main/templates/join_space/step1.html Show resolved Hide resolved
main/models/space_membership.py Show resolved Hide resolved
main/views.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants