Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyhook -> safetyhook #649

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Polyhook -> safetyhook #649

wants to merge 1 commit into from

Conversation

narknon
Copy link
Collaborator

@narknon narknon commented Sep 6, 2024

Issues: Hangs loading worlds after loading BPMod in Wukong

Copy link
Contributor

github-actions bot commented Sep 6, 2024

MSVC-Game__Debug__Win64 Download Logs
Build Details
Name Information
PR Commit b6d995c
Merge Commit e308a2f
Size 43.26 MB
Last Updated Oct 8, 24, 1:44:08 PM UTC
Expires At Oct 22, 24, 1:44:04 PM UTC

MSVC-Game__Shipping__Win64 Download Logs
Build Details
Name Information
PR Commit b6d995c
Merge Commit e308a2f
Size 25.17 MB
Last Updated Oct 8, 24, 1:48:13 PM UTC
Expires At Oct 22, 24, 1:48:11 PM UTC

@UE4SS
Copy link
Collaborator

UE4SS commented Sep 21, 2024

This PR completely removes PolyHook, and that will force mod creators that utilize PolyHook to update their code or re-add PolyHook themselves, this needs to be mentioned in the changelog.

@igromanru
Copy link
Contributor

Wait a minute.
Is it the same as #239?

fix: safetyhook compilation (localcc)

Add call_hook and call_hook_unsafe helper wrappers for Safetyhook

Add deprecation warning to polyhook_2 xmake file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants