Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FMapProperty to UnrealDef #554

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add FMapProperty to UnrealDef #554

wants to merge 2 commits into from

Conversation

narknon
Copy link
Collaborator

@narknon narknon commented Jun 3, 2024

No description provided.

@narknon narknon changed the base branch from main to TMapAndDTStaging June 3, 2024 15:29
@narknon narknon marked this pull request as ready for review June 3, 2024 15:29
localcc
localcc previously approved these changes Jun 17, 2024
@narknon narknon changed the base branch from TMapAndDTStaging to main October 8, 2024 13:13
@narknon narknon dismissed localcc’s stale review October 8, 2024 13:13

The base branch was changed.

using TMap = Unreal::TMap<T1, T2>;

template <typename T1, typename T2, typename T3, typename T4>
using TMap = Unreal::TMap<T1, T2, T3, T4>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this make every user of TMap broken?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't because elsewhere it sets defaults for the additional inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants