Skip to content

Commit

Permalink
Remove warning about using MSVC preview
Browse files Browse the repository at this point in the history
No longer necessary due to  #640
  • Loading branch information
narknon committed Aug 29, 2024
1 parent f4e749b commit 570c770
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions tools/xmakescripts/rules/version_rules.lua
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,6 @@ rule("check.msvc.ver")
cprint("checking for Microsoft C/C++ Compiler Toolset version ... ${color.success}%s", vctools_ver)
end

-- TEMPORARY, remove before next release
-- if the msvc is in preview, we should warn the user, but not block build
if compare_versions(parsed_vcvars_ver, parse_version("14.41.0")) then
cprint("${color.warning}your MSVC version may cause error on compile, please consider downgrading to this version or similar: (%s)", MINIMUM_MSVC_TOOLSET_VERSION)
end

-- could also do this
-- local vs_version = msvc:config("vcvars").VSCMD_VER
-- if vs_version:find("pre") then
Expand Down

0 comments on commit 570c770

Please sign in to comment.