Skip to content

Commit

Permalink
Rewrite build.py -> release.py and fix bugs (#542)
Browse files Browse the repository at this point in the history
* fix: rewrite build.py

- fix the outstanding bugs

* remove deleting all files at script end

as the files are used at the end of the build action

* remove unused args, help page

* chore: add extra docs

* another refactor pass

* fix changelog in release still having TBD date for latest release

* re-add is_experimental argument

as we don't want to change the changelog date if its experimental

* exit script and fail build if any cpp mod dlls aren't present

* cpp mods ship with pdbs on dev release

* add support for mods.json

* rename build.py to release.py

* review pass 2 fixes

* Remove build.py after merge conflicts

---------

Co-authored-by: gehigash <[email protected]>
  • Loading branch information
Buckminsterfullerene02 and bitonality committed Jun 14, 2024
1 parent 6cd4080 commit 142577b
Show file tree
Hide file tree
Showing 6 changed files with 399 additions and 302 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/experimental.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ on:
permissions:
contents: read

concurrency:
group: experimental-release
cancel-in-progress: true

jobs:
make-release:
permissions: write-all
Expand All @@ -31,7 +35,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v4
with:
python-version: '3.x'
python-version: '3.9'

- name: Setup MSVC
uses: ilammy/msvc-dev-cmd@v1
Expand All @@ -57,7 +61,7 @@ jobs:
xmake build
- name: Package
run: python tools/buildscripts/build.py package -e
run: python tools/buildscripts/release.py package -e

- name: Release
uses: softprops/action-gh-release@v1
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ on: workflow_dispatch
permissions:
contents: read

concurrency:
group: stable-release
cancel-in-progress: true

jobs:
make-release:
permissions: write-all
Expand All @@ -20,7 +24,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v4
with:
python-version: '3.x'
python-version: '3.9'

- name: Setup MSVC
uses: ilammy/msvc-dev-cmd@v1
Expand All @@ -32,7 +36,7 @@ jobs:

- name: Release Commit
id: release_commit
run: python build.py release_commit ${{ github.actor }}
run: python release.py release_commit ${{ github.actor }}
working-directory: ./tools/buildscripts

- name: Cache
Expand All @@ -51,7 +55,8 @@ jobs:
xmake build
- name: Package
run: python tools/buildscripts/build.py package
id: package
run: python tools/buildscripts/release.py package

- name: Push changes
uses: ad-m/github-push-action@master
Expand Down
42 changes: 42 additions & 0 deletions assets/Mods/mods.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
[
{
"mod_name": "CheatManagerEnablerMod",
"mod_enabled": true
},
{
"mod_name": "ActorDumperMod",
"mod_enabled": false
},
{
"mod_name": "ConsoleCommandsMod",
"mod_enabled": true
},
{
"mod_name": "ConsoleEnablerMod",
"mod_enabled": true
},
{
"mod_name": "SplitScreenMod",
"mod_enabled": false
},
{
"mod_name": "LineTraceMod",
"mod_enabled": true
},
{
"mod_name": "BPML_GenericFunctions",
"mod_enabled": true
},
{
"mod_name": "BPModLoaderMod",
"mod_enabled": true
},
{
"mod_name": "jsbLuaProfilerMod",
"mod_enabled": false
},
{
"mod_name": "Keybinds",
"mod_enabled": true
}
]
2 changes: 1 addition & 1 deletion assets/UE4SS-settings.ini
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ LoadAllAssetsBeforeGeneratingCXXHeaders = 0
IgnoreAllCoreEngineModules = 0

; Whether to skip generating the "Engine" and "CoreUObject" packages
; Default: 1
; Default: 0
IgnoreEngineAndCoreUObject = 0

; Whether to force all UFUNCTION macros to have "BlueprintCallable"
Expand Down
Loading

0 comments on commit 142577b

Please sign in to comment.