fix: shelfmark search #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourcefilter
force-pushed
the
2519-fix-shelfmark-search
branch
4 times, most recently
from
e3483f1
to
128c7cf
Compare
Search by shelfmark wasn't working, due to a typo that had the field type as "_tsi" instead of "_ssi". Investigating this, I also found and fixed a test that used "title_tsim" instead of "title_tesim"
sourcefilter
force-pushed
the
2519-fix-shelfmark-search
branch
from
128c7cf
to
11d4494
Compare
|
Will be using _tsi field. and will add the docker file change to a separate branch and ticket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search by shelfmark wasn't working, due to a typo that had the field type as "_tsi" instead of "_ssi". Investigating this, I also found and fixed a test that used "title_tsim" instead of "title_tesim"