Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS-1199 Reset Sinai id token to expire in 1 year #113

Merged

Conversation

jendiamond
Copy link
Member

@jendiamond jendiamond commented Nov 15, 2023

Connected to APPS-1199

The login token for Sinai was reset to expire after 3 days. This was a mistake and we would like the login prompt interval to be 1 year. John R. indicated that we should be able to make the change on our end without coordinating with EMEL.


This all has to happen at once. (which it did)

  • APPS team needs to deploy the changes to production in Jenkins.
  • SERVICES needs to merge in the changes to Cantalope's delegate script.
  • DEVSUPPORT needs to update the delegate URL to the new commit hash on production.
  • Then DEVSUPPORT needs to restart the production Cantalope container with ArgoCD to get it to pull the changes in.

Then, we all tested that it worked.

There may be issues with people who already have the cookies.
They will need to sign back in. They may need to clear their cookies first.
Dawn is aware of this and is ready to handle any confusion.

@jendiamond jendiamond self-assigned this Nov 15, 2023
@jendiamond jendiamond changed the title feat: APPS-1199 Reset sinai id token expiration to 1 year feat: APPS-1199 Reset Sinai id token expiration to 1 year Nov 15, 2023
@jendiamond jendiamond changed the title feat: APPS-1199 Reset Sinai id token expiration to 1 year feat: APPS-1199 Reset Sinai id token to expire in 1 year Nov 15, 2023
@jendiamond jendiamond force-pushed the APPS-1199_reset-sinai-id-token-expiration-to-1-year branch from 5dbfa7f to e731f2e Compare November 15, 2023 00:58
Copy link
Contributor

@sourcefilter sourcefilter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@sourcefilter sourcefilter merged commit 402430f into main Nov 17, 2023
6 checks passed
@sourcefilter sourcefilter deleted the APPS-1199_reset-sinai-id-token-expiration-to-1-year branch November 17, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants