Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot Hotfix: Merge targetSV with localYJS_SV before writing into localYJS_SV #177

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Snapshot Hotfix: Merge targetSV with localYJS_SV before writing into localYJS_SV #177

wants to merge 3 commits into from

Conversation

CAWorks-ChrisA
Copy link
Contributor

Untested due to expired local keys at docs/Bootstrap
Will update the keys again when I find time.
This should work, please test.

@CAWorks-ChrisA CAWorks-ChrisA changed the title Hotfix: Merge targetSV with localYJS_SV before writing into localYJS_SV Snapshot Hotfix: Merge targetSV with localYJS_SV before writing into localYJS_SV Jan 25, 2025
@zjkmxy zjkmxy self-assigned this Jan 30, 2025
@zjkmxy
Copy link
Collaborator

zjkmxy commented Feb 1, 2025

  • Underscore is not recommended in naming.
  • Please update the lock file correspondingly.

@CAWorks-ChrisA
Copy link
Contributor Author

CAWorks-ChrisA commented Feb 7, 2025 •
edited
Loading

  • Naming for underscore changed.
  • Please explain the lock file one. This hotfix only changes backend/main.ts, does it require the lock file (dependencies) to be updated?
  • Requested by others in IRL group, shortened the timeInterval for the 'stale' determination of local state down to 15min (from 24 hours)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zjkmxy zjkmxy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CAWorks-ChrisA @zjkmxy