Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alias for older remarkGfm versions #132

Closed
wants to merge 1 commit into from
Closed

Conversation

AnoldGH
Copy link
Contributor

@AnoldGH AnoldGH commented Aug 5, 2024

There is a conflict of remark-gfm version mentioned here

There is a GitHub-flavour plugin, but it depends on remark-gfm 4.0. The chat Markdown is incompatible with this version ([URGENT] Chat Markdown crashes on some input #127). Seek a way to handle this.

This update aliases the older version of remark-gfm (3.0.1) as remark-gfm-3.0.1 and resolves the conflict.

@zjkmxy
Copy link
Collaborator

zjkmxy commented Aug 5, 2024

NOT DESIRED.

  • The item in Support Markdown for document #125 is describing the FUTURE. Nothing needs to be done now. We have not identified any immediate issue, so why fix now?
  • Fundamentally, I don't want to install two versions of the same package. If possible, let's settle down to a single version. The code size is already very large, and I don't want to make it larger.

If you have time, would you mind fixing the UI (CSS specifically) of #131?
Thanks.

@zjkmxy zjkmxy closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants