Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[pre-commit.ci] pre-commit autoupdate" #482

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

paddyroddy
Copy link
Member

Reverts #479

We don't want the alpha version

@paddyroddy paddyroddy added the bug Something isn't working label Oct 29, 2024
@paddyroddy paddyroddy self-assigned this Oct 29, 2024
@paddyroddy
Copy link
Member Author

Another issue is this isn't going to update the template's ones. We don't want this on at all.

Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to keep these up to date, so see no reason to revert this. If you want to disable pre-commit.ci auto updating the versions, please could you open a new issue and we can discuss there?

@paddyroddy
Copy link
Member Author

@renovatebot will do it in 3 days...

@samcunliffe
Copy link
Member

🤷

I'm ok with alphas. But if we decide never to take pre-commit autoupdates and only use @renovate: can we actually disable it in the ci: config, please? It's not immediately clear to me but I guess it's possible.

@dstansby
Copy link
Member

I've re-opened #463 to discuss, so we can make sure discussion is in one place for future reference

@paddyroddy
Copy link
Member Author

I'm ok with alphas. But if we decide never to take pre-commit autoupdates and only use @renovate: can we actually disable it in the ci: config, please? It's not immediately clear to me but I guess it's possible.

It's not possible pre-commit-ci/issues#83

@paddyroddy
Copy link
Member Author

Also the problem is this doesn't update the template which @renovatebot would

@samcunliffe samcunliffe enabled auto-merge (squash) November 1, 2024 13:46
Copy link
Member

@samcunliffe samcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert this and add the bot back?

@samcunliffe samcunliffe dismissed dstansby’s stale review November 1, 2024 13:51

Testing the bot with forbidden branch naming rule

@samcunliffe samcunliffe merged commit 067b8a3 into main Nov 1, 2024
12 checks passed
@samcunliffe samcunliffe deleted the revert-479-pre-commit-ci-update-config branch November 1, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants