Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pages build on PRs that touch docs. #378

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

samcunliffe
Copy link
Member

@samcunliffe samcunliffe commented Jun 1, 2024

Should help notice bugs like #376#377.

Follows from

Along the way to solving

@samcunliffe samcunliffe added the documentation Improvements or additions to documentation label Jun 1, 2024
@samcunliffe samcunliffe marked this pull request as ready for review June 4, 2024 13:38
@samcunliffe samcunliffe requested a review from a team June 4, 2024 13:46
Copy link
Collaborator

@matt-graham matt-graham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫐

@samcunliffe samcunliffe merged commit b918e01 into main Jun 4, 2024
12 checks passed
@samcunliffe samcunliffe deleted the sc/attempt-to-run-pages-on-changes-to-docs branch June 4, 2024 15:37
@samcunliffe
Copy link
Member Author

For ref: you guys are welcome to merge anything of mine that you approve.

@paddyroddy
Copy link
Member

For ref: you guys are welcome to merge anything of mine that you approve.

Thank you for permission, but I'm not going to 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants