Hyphens vs underscores: the bug reported in #127. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcunliffe
force-pushed
the
sc/127-underscores-and-hyphens
branch
from
fb0c914
to
f246172
Compare
samcunliffe
changed the title
matt-graham
reviewed
Jul 31, 2023
matt-graham
reviewed
Jul 31, 2023
paddyroddy
approved these changes
Aug 2, 2023
Cheers Matt. Good spot.
Co-authored-by: Patrick Roddy <[email protected]>
samcunliffe
force-pushed
the
sc/127-underscores-and-hyphens
branch
from
609ce66
to
9565d46
Compare
|
@samcunliffe what's happening with this? |
|
@paddyroddy sorry... my bad. I let it go a bit stale. There are some action items for me from the comments above:
|
samcunliffe
added a commit
that referenced
this pull request
Oct 24, 2023
Decided to put __init__.py and rename 'module_name' to 'package_name' because it's a package. If advanced users want to make a namespace package then they can just remove __init__.py. Keep project_slug as the pip/pypi/repo name.
Decided to put __init__.py and rename 'module_name' to 'package_name' because it's a package. If advanced users want to make a namespace package then they can just remove __init__.py. Keep project_slug as the pip/pypi/repo name.
samcunliffe
force-pushed
the
sc/127-underscores-and-hyphens
branch
from
1b81d3a
to
bbc6dd4
Compare
|
Sorry for being slow. |
|
Can you resolve conflicts before review @samcunliffe? |
I did at the time of requesting. But there's too much development velocity here. |
Don't hate the player, hate the game |
|
Merging before I get overtaken by development velocity. @p-j-smith @matt-graham please shout if you want to revisit anything here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cheers @matt-graham. Good spot.