Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Path Bug #448

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Global Path Bug #448

merged 2 commits into from
Oct 27, 2024

Conversation

FireBoyAJ24
Copy link
Contributor

Description

Local pathfinding would break when initializing the reference_latlon in OMPLPath as the global path was not initialized as None in the LocalPathState. To fix that I just initialized global path to none and checked it when initializing the reference latlon.

Verification

  • Run the command ros2 launch local_pathfinding main_launch.py and ensured no errors was occuring.

@FireBoyAJ24 FireBoyAJ24 added bug Something isn't working path Pathfinding team labels Oct 27, 2024
Copy link
Contributor

@jamenkaye jamenkaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! Make sure the integration tests all pass before merging :)

@FireBoyAJ24 FireBoyAJ24 merged commit 8c9ea21 into main Oct 27, 2024
10 checks passed
@FireBoyAJ24 FireBoyAJ24 deleted the user/Jay/global_path_bug branch October 27, 2024 01:34
vaibhavambastha pushed a commit that referenced this pull request Nov 2, 2024
* Made global path none in localpathstate and checked it when initializing reference_latlon

* Changed the test case to not have localpathstate to be none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working path Pathfinding team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants