Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve simulator unit test warnings #446

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Resolve simulator unit test warnings #446

merged 1 commit into from
Oct 26, 2024

Conversation

eomielan
Copy link
Member

@eomielan eomielan commented Oct 26, 2024 •
edited
Loading

Description

  • This PR is to resolve warnings originating from the simulator fluid generation unit tests about covariance is not positive-semidefinite.

Verification

  • Ran unit tests. All tests pass + no more warnings.

@eomielan eomielan added the sim Boat Simulator team label Oct 26, 2024
@eomielan eomielan self-assigned this Oct 26, 2024
@eomielan eomielan merged commit 545e16c into main Oct 26, 2024
10 checks passed
@eomielan eomielan deleted the user/eomielan/fix_simulator_test_warnings branch October 26, 2024 22:18
vaibhavambastha pushed a commit that referenced this pull request Nov 2, 2024
@eomielan @vaibhavambastha
Resolve simulator unit test warnings (#446)
362f819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eomielan eomielan

Labels
sim Boat Simulator team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eomielan