Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve sensor and ROS message naming conflict #441

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

kristatraboulay
Copy link
Contributor

Description

-Resolved conflict between WindSensor and GPS classes and WindSensor and GPS ROS messages by renaming the classes

Verification

  • Ran boat_simulator tests, tests passed for modified files (test_wind_sensor.py and test_gps_sensor.py)

@kristatraboulay kristatraboulay self-assigned this Oct 19, 2024
Copy link
Member

@eomielan eomielan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristatraboulay kristatraboulay merged commit 3bf448c into main Oct 19, 2024
10 checks passed
@kristatraboulay kristatraboulay deleted the kristatraboulay/439-resolve_sensor_conflict branch October 19, 2024 21:37
vaibhavambastha pushed a commit that referenced this pull request Nov 2, 2024
* Changed sensor names to resolve ROS conflict

* Updated WindSensor to SimWindSensor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve conflict between sensor classes and ROS msg
2 participants